Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: not to generate partial agg when cop task has root condition… #15141

Merged
merged 7 commits into from
Mar 13, 2020
Merged

planner: not to generate partial agg when cop task has root condition… #15141

merged 7 commits into from
Mar 13, 2020

Conversation

lzmhhh123
Copy link
Contributor

release-3.1 cherry-pick: #15112
conflicts: planner/core/task.go

@lzmhhh123 lzmhhh123 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/3.1-cherry-pick labels Mar 5, 2020
@lzmhhh123
Copy link
Contributor Author

/run-unit-test

francis0407
francis0407 reviewed Mar 5, 2020
View reviewed changes
Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

winoros
winoros previously approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@disksing
Copy link
Contributor

/run-integration-common-test

@windtalker windtalker mentioned this pull request Mar 13, 2020
Merged
eurekaka
eurekaka approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 13, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 13, 2020

/run-all-tests

@sre-bot sre-bot merged commit c00c4d9 into pingcap:release-3.1 Mar 13, 2020
@lzmhhh123 lzmhhh123 deleted the release-3.1-cherry-pick-flash branch March 13, 2020 06:59
@lzmhhh123 lzmhhh123 mentioned this pull request Mar 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francis0407 francis0407 francis0407 left review comments

@eurekaka eurekaka eurekaka approved these changes

@winoros winoros winoros left review comments

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lzmhhh123 @disksing @eurekaka @sre-bot @winoros @francis0407 @zz-jason