infoschema: Migrate the infoschema's retrieving data logic for 'CharacterSets/Collations' to executor #15103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lonng @crazycs520 PTAL |
AndrewDi
changed the title
|
/rebuild |
Codecov Report
@@ Coverage Diff @@
## master #15103 +/- ##
================================================
- Coverage 80.3701% 80.3299% -0.0402%
================================================
Files 502 502
Lines 131896 131896
================================================
- Hits 106005 105952 -53
- Misses 17527 17565 +38
- Partials 8364 8379 +15 |
reafans
reviewed
Mar 3, 2020
|
/run-all-tests |
lonng
added
sig/execution
|
lgtm |
reafans
approved these changes
Mar 3, 2020
reafans
added
status/LGT2
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@AndrewDi merge failed. |
|
/rebuild |
This was referenced Mar 4, 2020
|
/award-point 100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UCP #15040 #15035
What problem does this PR solve?
Infoschema contains too much logic for retrieving data, which is confusing, we need to migrate this part to the executor so that infoshema only contains schema information. Detail ref #15040 #15035
What is changed and how it works?
migrate function dataForCharacterSets/dataForCollations from infoschema pkg to executor/infoschema_reader.go
Check List
Tests
Code changes