ddl, config: add a variable to control the max index length (#15012) #15083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
component/DDL
priority/release-blocker
djshow832
reviewed
Mar 3, 2020
Comment on lines
+187
to
+191
| <<<<<<< HEAD | ||
| ======= | ||
| mem-quota-query = 10000 | ||
| max-index-length = 3080 | ||
| >>>>>>> 1771cf8... ddl, config: add a variable to control the max index length (#15012) |
Comment on lines
+244
to
+256
| <<<<<<< HEAD | ||
| ======= | ||
| c.Assert(conf.MaxIndexLength, Equals, 3080) | ||
|
|
||
| _, err = f.WriteString(` | ||
| [log.file] | ||
| log-rotate = true`) | ||
| c.Assert(err, IsNil) | ||
| err = conf.Load(configFile) | ||
| tmp := err.(*ErrConfigValidationFailed) | ||
| c.Assert(isAllDeprecatedConfigItems(tmp.UndecodedItems), IsTrue) | ||
|
|
||
| >>>>>>> 1771cf8... ddl, config: add a variable to control the max index length (#15012) |
|
Don't need to cherry-pick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15012 to release-4.0
What problem does this PR solve?
Before #13727(v3.0.8):
After #13727:
Therefore, in v3.0.8 and after, such statements will report an error, which is not compatible with the behavior of versions before v3.0.8.
What is changed and how it works?
Add a variable to control the max index length. And the value range is [3072, 3072*4].
The default value is 3072, it is consistent with MySQL.
Check List
Tests
Related changes
Release note