planner: fold constant in projection elimination and TopN push down #14927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/bugfix
ghost
requested review from
francis0407 and
alivxxx
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #14927 +/- ##
================================================
+ Coverage 80.2223% 80.2591% +0.0368%
================================================
Files 503 503
Lines 130905 130911 +6
================================================
+ Hits 105015 105068 +53
+ Misses 17586 17552 -34
+ Partials 8304 8291 -13 |
|
/rebuild |
|
/merge |
sre-bot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 14664 |
|
/run-all-tests |
|
@eurekaka merge failed. |
|
/run-unit-test |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-4.0 failed |
This was referenced Feb 26, 2020
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1 release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @eurekaka PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #14926.
What is changed and how it works?
Fold constant in projection elimination. TopN pushdown check is unnecessary for this case actually, but we can enforce it to prevent potential bugs incurred by patches from future.
Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes
Release note
fix wrong result for queries with single MAX() over UNION