Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: implement disk/cpu/memory/load diagnosis rules #14668

Merged
merged 18 commits into from
Feb 10, 2020
Merged

executor: implement disk/cpu/memory/load diagnosis rules #14668

merged 18 commits into from
Feb 10, 2020

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Feb 7, 2020

What problem does this PR solve?

This PR introduces a new diagnosis rule which uses to determine the current CPU/disk/memory/load usage at a rational range.

What is changed and how it works?

Implement the new diagnosis rule.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

  • Implements new diagnosis rule which uses to determine the current CPU/disk/memory/load usage at a rational range.

Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
@lonng lonng requested a review from a team as a code owner February 7, 2020 04:09
@ghost ghost requested review from alivxxx and winoros and removed request for a team February 7, 2020 04:09
@lonng lonng added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution labels Feb 7, 2020
@lonng lonng added this to the v4.0.0-beta.1 milestone Feb 7, 2020
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
@lonng lonng requested review from crazycs520 and djshow832 and removed request for alivxxx and winoros February 7, 2020 06:57
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
executor/cluster_reader.go Outdated Show resolved Hide resolved
executor/diagnostics.go Show resolved Hide resolved
Signed-off-by: Lonng <heng@lonng.org>
@lonng
Copy link
Contributor Author

lonng commented Feb 10, 2020

/run-all-tests

djshow832
djshow832 previously approved these changes Feb 10, 2020
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng changed the title diagnostics: implement disk/cpu/memory/load rules executor: implement disk/cpu/memory/load diagnosisi rules Feb 10, 2020
@lonng lonng changed the title executor: implement disk/cpu/memory/load diagnosisi rules executor: implement disk/cpu/memory/load diagnosis rules Feb 10, 2020
@lonng
Copy link
Contributor Author

lonng commented Feb 10, 2020

/run-all-tests

Signed-off-by: Lonng <heng@lonng.org>
@lonng lonng merged commit 56438a0 into pingcap:master Feb 10, 2020
@lonng lonng deleted the diag-rules branch February 10, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants