-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: make the read storage hint not force plan #14644
Merged
lzmhhh123
merged 5 commits into
pingcap:master
from
lzmhhh123:bug-fix/wrong-hint-behavior
Feb 10, 2020
Merged
planner: make the read storage hint not force plan #14644
lzmhhh123
merged 5 commits into
pingcap:master
from
lzmhhh123:bug-fix/wrong-hint-behavior
Feb 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
francis0407 and
alivxxx
and removed request for
a team
February 5, 2020 06:57
alivxxx
reviewed
Feb 7, 2020
alivxxx
reviewed
Feb 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
windtalker
reviewed
Feb 10, 2020
windtalker
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lzmhhh123
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Feb 10, 2020
/run-all-tests |
@lzmhhh123 merge failed. |
/run-unit-test |
1 similar comment
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Set TiFlash isolation.
It looks a good behavior.
Then set TiKV isolation.
That's not the same behavior of TiFlash isolation read.
What is changed and how it works?
Remove the TODO in set hint storage type and make the hint not force the possible path for the
DataSource
.Check List
Tests
Code changes