Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: change field name 'password' to 'authentication_string' in mysql.user #14598

Merged
merged 7 commits into from
Feb 19, 2020
Merged

*: change field name 'password' to 'authentication_string' in mysql.user #14598

merged 7 commits into from
Feb 19, 2020

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Feb 3, 2020

What problem does this PR solve?

Fix a part of #9655.

What is changed and how it works?

Change field name password to authentication_string in mysql.user.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has persistent data change

Side effects

  • Breaking forward compatibility: Running old version TiDB with new data will complain
["load mysql.user fail"] [error="[planner:1054]Unknown column 'password' in 'field list'"]

Related changes

  • Need to update the documentation

Release note

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 12, 2020
@tiancaiamao tiancaiamao mentioned this pull request Feb 12, 2020
Merged
bb7133
bb7133 previously approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 13, 2020
@bb7133 bb7133 added this to the v4.0.0-beta.1 milestone Feb 13, 2020
@bb7133
Copy link
Member

bb7133 commented Feb 13, 2020

Hi @tangenta , please update the release note in this PR Description.

@bb7133 bb7133 added the status/can-merge Indicates a PR has been approved by a committer. label Feb 13, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 13, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 13, 2020

@tangenta merge failed.

tiancaiamao
tiancaiamao previously approved these changes Feb 13, 2020
View reviewed changes
@wjhuang2016
Copy link
Member

/run-all-tests

@tiancaiamao
Copy link
Contributor

Please address conflicts @tangenta

@tangenta tangenta dismissed stale reviews from tiancaiamao and bb7133 via 3c62e00 February 18, 2020 09:50
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao
Copy link
Contributor

/run-all-tests

@tiancaiamao tiancaiamao merged commit 344c48d into pingcap:master Feb 19, 2020
@kennytm kennytm mentioned this pull request Feb 21, 2020
Open
@coocood coocood mentioned this pull request Mar 4, 2020
Closed
@siddontang
Copy link
Member

@GregoryIan

Does DM have the problem if sync MySQL 5.6/5.7 to the newest TiDB?

@tangenta tangenta mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@bb7133 bb7133 bb7133 left review comments

Assignees
No one assigned
Labels
component/mysql-protocol status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Milestone
v4.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
6 participants
@tangenta @tiancaiamao @bb7133 @sre-bot @wjhuang2016 @siddontang