-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: trace the memory usage of Projection executors #13914
Conversation
/rebuild |
Codecov Report
@@ Coverage Diff @@
## master #13914 +/- ##
===========================================
Coverage 80.5325% 80.5325%
===========================================
Files 483 483
Lines 123288 123288
===========================================
Hits 99287 99287
Misses 16245 16245
Partials 7756 7756 |
/run-all-tests |
/run-integration-common-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please add a test that shows after the execution the memTracker will be 0? Just like
Line 126 in 0a22034
c.Assert(response.memTracker.BytesConsumed(), Equals, int64(0)) |
Rest LGTM.
updated, PTAL~ |
After testing, I find it's hard to guarantee it is zero since when the main goroutine exit, other worker-goroutines may be still running and chunks hold by them are hard to trace then. |
Could you explain it with more detail? |
We can use |
/run-all-tests |
All comments are addressed, PTAL @SunRunAway @ichn-hu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@qw4990 merge failed. |
/run-all-tests |
What problem does this PR solve?
Trace the memory usage of Projection executors and display the result in
Explain Analyze
.Check List
Tests