expression: open push down switcher for part of CAST functions #13837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
qw4990 and
XuHuaiyu
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #13837 +/- ##
===========================================
Coverage ? 80.1556%
===========================================
Files ? 474
Lines ? 117066
Branches ? 0
===========================================
Hits ? 93835
Misses ? 15819
Partials ? 7412 |
Signed-off-by: Lonng <heng@lonng.org>
…wn-cast Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>
ghost
requested review from
eurekaka and
winoros
and removed request for
a team
iosmanthus
changed the title
|
|
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>
|
/run-integration-common-test tidb-test=pr/960 |
Signed-off-by: Lonng <heng@lonng.org>
|
/run-integration-common-test tidb-test=pr/960 |
|
/run-all-tests tidb-test=pr/960 |
XuHuaiyu
changed the title
XuHuaiyu
reviewed
Jan 2, 2020
qw4990
added
the
status/can-merge
|
/run-all-tests |
|
@lonng merge failed. |
|
/run-integration-common-test tidb-test=pr/960 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
Open the CAST push-down switcher and fix some execution plans.
What is changed and how it works?
We have fixed all CAST functions related inconsistent between TiDB and TiKV, it's time to open the switcher default.
Check List
Tests
Release note