Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: add bit column test about display width range (#11985) #13737

Merged
merged 5 commits into from
Dec 18, 2019

Conversation

tangenta
Copy link
Contributor

Cherry-pick #11985.
Fix #13734.

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2019
zz-jason
zz-jason previously approved these changes Dec 3, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/DDL-need-LGT3 status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 3, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

Your auto merge job has been accepted, waiting for 13784, 13306

@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

@tangenta merge failed.

@jackysp
Copy link
Member

jackysp commented Dec 6, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 6, 2019

Your auto merge job has been accepted, waiting for 13892, 13932, 13784, 13306

@sre-bot
Copy link
Contributor

sre-bot commented Dec 6, 2019

@tangenta merge failed.

zz-jason
zz-jason previously approved these changes Dec 17, 2019
@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 17, 2019

Your auto merge job has been accepted, waiting for 14014

@sre-bot
Copy link
Contributor

sre-bot commented Dec 17, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 17, 2019

@tangenta merge failed.

@ngaut
Copy link
Member

ngaut commented Dec 18, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2019

/run-all-tests

@ngaut ngaut merged commit c598e4b into pingcap:release-3.0 Dec 18, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants