planner: adjust the cost model of Apply #13550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13550 +/- ##
==========================================
Coverage ? 80.251%
==========================================
Files ? 472
Lines ? 114725
Branches ? 0
==========================================
Hits ? 92068
Misses ? 15438
Partials ? 7219 |
eurekaka
reviewed
Nov 20, 2019
# Conflicts: # planner/core/task.go
|
@francis0407, please update your pull request. |
ghost
requested review from
lzmhhh123 and
winoros
and removed request for
a team
|
@francis0407, please update your pull request. |
|
/merge |
sre-bot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 14263 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The cost of Apply was only calculated by
selfCost + leftCost, which did not consider the cost of the outer side.What is changed and how it works?
Integrate the cost of outer side into the cost model of Apply.
Check List
Tests
Code changes