-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: implement vectorized evaluation for builtinCastDurationAsRealSig
#13475
expression: implement vectorized evaluation for builtinCastDurationAsRealSig
#13475
Conversation
Thanks for your contribution. If your PR get merged, you will be rewarded 50 points. |
85089de
to
1227900
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
89966f1
to
e311a3c
Compare
Codecov Report
@@ Coverage Diff @@
## master #13475 +/- ##
================================================
+ Coverage 80.2004% 80.2467% +0.0463%
================================================
Files 472 472
Lines 114866 114791 -75
================================================
- Hits 92123 92116 -7
+ Misses 15495 15449 -46
+ Partials 7248 7226 -22 |
/run-all-tests |
/rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PCP #12105
What problem does this PR solve?
Implement vectorized evaluation for builtinCastDurationAsRealSig at #12105
What is changed and how it works?
It gets faster about 1.2%.
Duration.ToNumber()
is modified, just as what is done inCheckFsp()
fromfsp.go
. OtherwisebuiltinCastDurationAsRealSig.evalReal()
inbuiltin_cast.go
will raise aruntime error: slice bounds out of range [:-1]
in unittest ofbuiltinCastDurationAsRealSig.vecEvalReal()
.Check List
Tests