executor: getNewJoinResult after handling a task for orderd IndexHashJoin #13451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13451 +/- ##
===========================================
Coverage 80.2545% 80.2545%
===========================================
Files 472 472
Lines 115014 115014
===========================================
Hits 92304 92304
Misses 15458 15458
Partials 7252 7252 |
SunRunAway
reviewed
Nov 15, 2019
| cancelFunc() | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
Is it better to put it in doJoinInOrder or handleTask?
There was a problem hiding this comment.
How about putting it here, the first defer function in doJoinInOrder?
lzmhhh123
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 13561 |
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #13449
What is changed and how it works?
This bug will only be triggered when IndexHashJoin needs to keep the outer order.
inner workerwill return the join result back to themain threadand fetch another task WITHOUTgetNewJoinResult.chkResourceChwill be FULL at the moment.main threadwill be BLOCKED when try to send the result chk, which is fetched in step 1, back to the correspondingchkResourceCh.inner workerwill be BLOCKED when try to send a new join result to the main thread because there is no one wait on the result channel.Check List
Tests
Code changes
Side effects
N/A
Related changes
N/A
Release note
N/A