Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove useless code #13439

Merged
merged 2 commits into from
Nov 13, 2019
Merged

Conversation

wjhuang2016
Copy link
Member

What problem does this PR solve?

Clean code.

What is changed and how it works?

remove useless code

Check List

Tests

  • No code

@wjhuang2016 wjhuang2016 requested a review from a team as a code owner November 13, 2019 11:47
@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team November 13, 2019 11:47
@wjhuang2016 wjhuang2016 requested a review from winoros November 13, 2019 11:48
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason zz-jason changed the title planner: remove useless code expression: remove useless code Nov 13, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Nov 13, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 13, 2019

/run-all-tests

@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #13439 into master will decrease coverage by 0.3391%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             master    #13439        +/-   ##
===============================================
- Coverage   80.5381%   80.199%   -0.3392%     
===============================================
  Files           471       471                
  Lines        115611    113363      -2248     
===============================================
- Hits          93111     90916      -2195     
- Misses        15345     15384        +39     
+ Partials       7155      7063        -92

@sre-bot sre-bot merged commit 4a5bc92 into pingcap:master Nov 13, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants