Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, stats: extract topn from cm sketch (#11409) #13429

Merged
merged 1 commit into from
Nov 13, 2019
Merged

executor, stats: extract topn from cm sketch (#11409) #13429

merged 1 commit into from
Nov 13, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Nov 13, 2019

Cherry pick #11409

lzmhhh123
lzmhhh123 reviewed Nov 13, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 13, 2019
eurekaka
eurekaka approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/can-merge Indicates a PR has been approved by a committer. label Nov 13, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 13, 2019

/run-all-tests

@sre-bot sre-bot merged commit 819d633 into pingcap:release-3.0 Nov 13, 2019
@alivxxx alivxxx deleted the extract-topn-3.0 branch November 14, 2019 03:12
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@eurekaka eurekaka eurekaka approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/statistics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alivxxx @sre-bot @eurekaka @lzmhhh123 @zz-jason