sysvars: error code package for sysvar.go #13366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
qw4990 and
wshwsh12
and removed request for
a team
jackysp
reviewed
Nov 11, 2019
| ErrMaxPreparedStmtCountReached = terror.ClassVariable.New(CodeMaxPreparedStmtCountReached, mysql.MySQLErrName[mysql.ErrMaxPreparedStmtCountReached]) | ||
| ErrUnsupportedValueForVar = terror.ClassVariable.New(CodeUnknownStatusVar, "variable '%s' does not yet support value: %s") | ||
| ErrUnsupportedIsolationLevel = terror.ClassVariable.New(CodeUnknownStatusVar, "The isolation level '%s' is not supported. Set tidb_skip_isolation_level_check=1 to skip this error") | ||
| ErrUnsupportedValueForVar = terror.ClassVariable.New(mysql.ErrUnsupportedValueForVar, mysql.MySQLErrName[mysql.ErrUnsupportedValueForVar]) |
There was a problem hiding this comment.
Please add some test cases for the code of these errors.
Codecov Report
@@ Coverage Diff @@
## master #13366 +/- ##
===========================================
Coverage 80.1903% 80.1903%
===========================================
Files 469 469
Lines 112612 112612
===========================================
Hits 90304 90304
Misses 15311 15311
Partials 6997 6997 |
jackysp
added
the
status/can-merge
|
/run-all-tests |
|
@cfzjywxk merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for 12793 |
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Not all the errors in this file have error code. the error code added in parser is link
What is changed and how it works?
Add the missing ones and do some tiny refactorations
Check List
Tests
Code changes
Side effects
Related changes
Release note