distsql: Unify endian for Chunk encode format #13349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wshwsh12 <793703860@qq.com>
Signed-off-by: wshwsh12 <793703860@qq.com>
|
/build |
Codecov Report
@@ Coverage Diff @@
## master #13349 +/- ##
===========================================
Coverage 80.1863% 80.1863%
===========================================
Files 474 474
Lines 116753 116753
===========================================
Hits 93620 93620
Misses 15761 15761
Partials 7372 7372 |
|
/run-all-tests |
SunRunAway
reviewed
Nov 25, 2019
distsql/distsql.go
Outdated
| @@ -169,5 +170,35 @@ func canUseChunkRPC(ctx sessionctx.Context) bool { | |||
| if ctx.GetSessionVars().EnableStreaming { | |||
| return false | |||
| } | |||
| if !supportedAlignment() { | |||
There was a problem hiding this comment.
We may check this when process starting and cache the result, instead of checking in each session.
distsql/distsql.go
Outdated
|
|
||
| // SetSystemEndian sets the system endian for the DAGRequest. | ||
| func SetSystemEndian(dagReq *tipb.DAGRequest) { | ||
| dagReq.TidbSystemEndian = GetSystemEndian() |
There was a problem hiding this comment.
We may check this when process starting and cache the result, instead of checking in each session.
SunRunAway
reviewed
Nov 26, 2019
|
And PTAL at the CI failure. |
The CI fail is because tipb hasn't been merged to master and update. |
SunRunAway
changed the title
XuHuaiyu
reviewed
Nov 26, 2019
wshwsh12
added
status/LGT2
XuHuaiyu
approved these changes
Nov 27, 2019
XuHuaiyu
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When using chunk encode format for response , maybe the endian is different in tidb and tikv, and tidb can't decode the data.
What is changed and how it works?
Unify endian for Chunk encode format.
Check List
Tests
Code changes
Side effects
Related changes
Release note