Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix TestShowTableRegion #13234

Merged
merged 3 commits into from
Nov 7, 2019
Merged

executor: fix TestShowTableRegion #13234

merged 3 commits into from
Nov 7, 2019

Conversation

SunRunAway
Copy link
Contributor

@SunRunAway SunRunAway commented Nov 7, 2019 •
edited
Loading

What problem does this PR solve?

TestSplitRegion and TestShowTableRegion can not run in parallel.
Fix #13222

What is changed and how it works?

Check List

Tests

  • No code

@SunRunAway
Copy link
Contributor Author

/run-all-tests

@codecov
Copy link

codecov bot commented Nov 7, 2019 •
edited
Loading

Codecov Report

Merging #13234 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13234   +/-   ##
===========================================
  Coverage   80.3898%   80.3898%           
===========================================
  Files           469        469           
  Lines        112508     112508           
===========================================
  Hits          90445      90445           
  Misses        15149      15149           
  Partials       6914       6914

@SunRunAway
Copy link
Contributor Author

/run-unit-test

zz-jason
zz-jason reviewed Nov 7, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 7, 2019
wjhuang2016
wjhuang2016 approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 7, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 7, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 7, 2019

@SunRunAway merge failed.

@SunRunAway SunRunAway merged commit 559f5ea into pingcap:master Nov 7, 2019
@SunRunAway SunRunAway deleted the TestShowTableRegion branch November 7, 2019 06:32
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@SunRunAway @XiaTianliang
executor: fix TestShowTableRegion (pingcap#13234)
4ff105e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees
No one assigned
Labels
component/test sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unit test fails in TestShowTableRegion
5 participants
@SunRunAway @sre-bot @zz-jason @wjhuang2016 @XuHuaiyu