*: support capture evolve plan tasks #13199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
reviewed
Nov 11, 2019
Co-Authored-By: Kenan Yao <cauchy1992@gmail.com>
winoros
reviewed
Nov 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #13199 +/- ##
===========================================
Coverage 80.7114% 80.7114%
===========================================
Files 471 471
Lines 116079 116079
===========================================
Hits 93689 93689
Misses 15293 15293
Partials 7097 7097 |
winoros
reviewed
Nov 13, 2019
| @@ -88,10 +96,13 @@ func Optimize(ctx context.Context, sctx sessionctx.Context, node ast.Node, is in | |||
| bestPlanAmongHints = plan | |||
| } | |||
| } | |||
| // If there is already a evolution task, we do not need to handle it again. | |||
| if sctx.GetSessionVars().EvolvePlanBaselines && binding == nil { | |||
There was a problem hiding this comment.
If don't want to evolve baseline or there's existing binding, can we just break and return here?
There was a problem hiding this comment.
No, it needs to handle the case of UsePlanBaselines.
alivxxx
added
status/LGT2
|
/run-all-tests |
|
@lamxTyler merge failed. |
|
/run-integration-copr-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support capture evolve plan tasks, which will be used to evolve plan tasks in next pr.
What is changed and how it works?
In planner, when we found that the best plan is not in the baselines and option of evolvement has been turned on, it will cache the best plan in memory, and the background job will check the cache periodically and save it to store if there are any tasks.
Check List
Tests
Code changes
Side effects
Related changes
Release note