Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorization for builtinCoalesceRealSig #13163

Closed
wants to merge 1 commit into from
Closed

expression: implement vectorization for builtinCoalesceRealSig #13163

wants to merge 1 commit into from

Conversation

PiotrNewt
Copy link
Contributor

What problem does this PR solve?

Implement vectorized evaluation for builtinCoalesceRealSig, for issue #12105

What is changed and how it works?

  • Implement vectorized evaluation.
  • Add a LogicalORNulls func to merges columns' null bitmaps by using logical OR
BenchmarkVectorizedBuiltinCompareFunc/builtinCoalesceRealSig-VecBuiltinFunc-4                     191886              5851 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinCompareFunc/builtinCoalesceRealSig-NonVecBuiltinFunc-4                   52080             22656 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@PiotrNewt PiotrNewt requested a review from a team as a code owner November 5, 2019 11:44
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 5, 2019
@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team November 5, 2019 11:44
qw4990
qw4990 reviewed Nov 5, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emm, it's sorry to say that all CoalesceXXX functions have been vectorized by this PR/13015.

@PiotrNewt
Copy link
Contributor Author

Oh, that's OK

@PiotrNewt PiotrNewt closed this Nov 5, 2019
@PiotrNewt PiotrNewt deleted the vecexpr-func-CoalesceReal branch November 5, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PiotrNewt @qw4990 @sre-bot