Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinDayNameSig #12940

Closed
wants to merge 2 commits into from
Closed

expression: implement vectorized evaluation for builtinDayNameSig #12940

wants to merge 2 commits into from

Conversation

mmyj
Copy link
Member

@mmyj mmyj commented Oct 25, 2019

What problem does this PR solve?

implement vectorized evaluation for builtinDayNameSig, for #12105

What is changed and how it works?

go test -v -benchmem -bench=BenchmarkVectorizedBuiltinTimeFunc -run=BenchmarkVectorizedBuiltinTimeFunc -args 'builtinDayNameSig'
goos: linux
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinTimeFuncGenerated-4   	1000000000	         0.00832 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinDayNameSig-VecBuiltinFunc-4         	   10000	    110411 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinDayNameSig-NonVecBuiltinFunc-4      	    8022	    143467 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/pingcap/tidb/expression	2.374s

@mmyj mmyj requested a review from a team as a code owner October 25, 2019 15:45
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 25, 2019
@ghost ghost requested review from wshwsh12 and removed request for a team October 25, 2019 15:45
@mmyj mmyj closed this Oct 25, 2019
@mmyj mmyj deleted the builtinDayNameSig branch November 14, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmyj @sre-bot