Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: unfold the wildcard when creating view (#11818) #12912

Merged
merged 3 commits into from
Oct 28, 2019
Merged

planner: unfold the wildcard when creating view (#11818) #12912

merged 3 commits into from
Oct 28, 2019

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Oct 24, 2019 •
edited
Loading

cherry-pick #11818

conflict files: planner/core/logical_plan_builder.go

What problem does this PR solve?

As part of View implement, remove view's wildcard and expand it.

What is changed and how it works?

ref proposal Proposal: Implement View

Check List

Tests

  • Unit test

Description

Let's take a example with create view,

CREATE VIEW V AS SELECT *FROM mysql.tidb

Before this PR，View will store select statement like

SELECT * FROM mysql.tidb

After this PR, View will store select statement like

SELECT VARIABLE_NAME,VARIABLE_VALUE,COMMENT FROM mysql.tidb

@XuHuaiyu XuHuaiyu added needs-cherry-pick-3.0 type/enhancement The issue or PR belongs to an enhancement. labels Oct 24, 2019
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu
Copy link
Contributor Author

/run-common-test tidb-test=pr/930
/run-integration-common-test tidb-test=pr/930

1 similar comment
@XuHuaiyu
Copy link
Contributor Author

/run-common-test tidb-test=pr/930
/run-integration-common-test tidb-test=pr/930

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=pr/930

SunRunAway
SunRunAway reviewed Oct 25, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2019
zz-jason
zz-jason approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

Your auto merge job has been accepted, waiting for 12936

@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

/run-all-tests

@sre-bot sre-bot merged commit 1019012 into pingcap:release-3.0 Oct 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

cherry pick to release-3.0 failed

@XuHuaiyu XuHuaiyu deleted the release-3.0 branch October 28, 2019 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@zz-jason zz-jason zz-jason approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XuHuaiyu @sre-bot @SunRunAway @zz-jason @AndrewDi