-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix incorrect result of logical operators (#12173) #12811
Merged
eurekaka
merged 7 commits into
pingcap:release-3.0
from
SunRunAway:automated-cherry-pick-of-#12173-upstream-release-3.0
Oct 18, 2019
Merged
expression: fix incorrect result of logical operators (#12173) #12811
eurekaka
merged 7 commits into
pingcap:release-3.0
from
SunRunAway:automated-cherry-pick-of-#12173-upstream-release-3.0
Oct 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunRunAway
added
component/expression
type/3.0 cherry-pick
type/bugfix
This PR fixes a bug.
labels
Oct 18, 2019
SunRunAway
force-pushed
the
automated-cherry-pick-of-#12173-upstream-release-3.0
branch
from
October 18, 2019 07:19
152f3c4
to
8096263
Compare
…upstream-release-3.0
/run-all-tests |
SunRunAway
requested review from
zz-jason,
XuHuaiyu,
qw4990 and
eurekaka
and removed request for
zz-jason
October 18, 2019 07:40
XuHuaiyu
reviewed
Oct 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SunRunAway
added
the
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
label
Oct 18, 2019
…upstream-release-3.0
zimulala
added
status/all tests passed
status/LGT2
Indicates that a PR has LGTM 2.
labels
Oct 18, 2019
eurekaka
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…upstream-release-3.0
…upstream-release-3.0
SunRunAway
deleted the
automated-cherry-pick-of-#12173-upstream-release-3.0
branch
October 18, 2019 09:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/expression
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated cherry pick of #12173 on release-3.0.
What problem does this PR solve?
Fix issue #11199
What is changed and how it works?
Wrap the input parameters of the builtin
AND
、OR
andXOR
operators withIS TRUE
function before cast them toint
type.Check List
Tests
Code changes
Side effects
Related changes
Release note