Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix constant propagation for AntiSemiJoin (#12728) #12800

Merged
merged 2 commits into from
Oct 18, 2019

Conversation

eurekaka
Copy link
Contributor

cherry-pick #12728

Conflicts:
cmd/explaintest/r/tpch.result
planner/core/integration_test.go
planner/core/logical_plan_builder.go
planner/core/logical_plan_test.go

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Oct 17, 2019
@zyxbest
Copy link
Contributor

zyxbest commented Oct 17, 2019

/build

Conflicts:
	cmd/explaintest/r/tpch.result
	planner/core/integration_test.go
	planner/core/logical_plan_builder.go
	planner/core/logical_plan_test.go
@eurekaka
Copy link
Contributor Author

/rebuild

@zyxbest
Copy link
Contributor

zyxbest commented Oct 18, 2019

/run-check_dev

@zyxbest
Copy link
Contributor

zyxbest commented Oct 18, 2019

/run-unit-test

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/can-merge Indicates a PR has been approved by a committer. label Oct 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2019

Your auto merge job has been accepted, waiting for 12810

@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit 0ce1a41 into pingcap:release-2.1 Oct 18, 2019
@eurekaka eurekaka deleted the pick_anti_21 branch October 18, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants