Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* : Multiple rows insert in a statement should have consecutive autoID if needed. (#11876) #12619

Merged
merged 4 commits into from
Oct 14, 2019
Merged

* : Multiple rows insert in a statement should have consecutive autoID if needed. (#11876) #12619

merged 4 commits into from
Oct 14, 2019

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

cherry-pick #11876 to release-2.1

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Keep the consecutive autoID allocation in a single insert statement. Now we can guarantee the consecutive autoid in statement like "insert into table values (row),(row),(row)...".

@AilinKid
Copy link
Contributor Author

/run-all-tests

@AilinKid AilinKid changed the title dml : Multiple rows insert in a statement should have consecutive autoID if needed. (#11876) * : Multiple rows insert in a statement should have consecutive autoID if needed. (#11876) Oct 11, 2019
@AilinKid
Copy link
Contributor Author

/run-all-tests

@AilinKid
Copy link
Contributor Author

/bench

bb7133
bb7133 reviewed Oct 12, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2019
@crazycs520
Copy link
Contributor

/run-all-tests

crazycs520
crazycs520 approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid AilinKid added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 14, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 14, 2019

Sorry @AilinKid, you don't have permission to trigger auto merge event on this branch.

@AilinKid AilinKid removed the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2019
@ngaut ngaut merged commit df41474 into pingcap:release-2.1 Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AilinKid @crazycs520 @sre-bot @bb7133 @ngaut