Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* : Multiple rows insert in a statement should have consecutive autoID if needed. (#11876) #12602

Merged
merged 5 commits into from
Oct 13, 2019
Merged

* : Multiple rows insert in a statement should have consecutive autoID if needed. (#11876) #12602

merged 5 commits into from
Oct 13, 2019

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

cherry-pick #11876 to release-3.0

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Keep the consecutive autoID allocation in a single insert statement. Now we can guarantee the consecutive autoid in statement like "insert into table values (row),(row),(row)...".

@AilinKid
Copy link
Contributor Author

/run-all-tests

@AilinKid
Copy link
Contributor Author

/run-all-tests

@AilinKid
Copy link
Contributor Author

/bench

bb7133
bb7133 reviewed Oct 12, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2019
zz-jason
zz-jason approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 13, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 13, 2019

Your auto merge job has been accepted, waiting for 12566, 12404

@sre-bot
Copy link
Contributor

sre-bot commented Oct 13, 2019

/run-all-tests

@sre-bot sre-bot merged commit 6596890 into pingcap:release-3.0 Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AilinKid @sre-bot @bb7133 @zz-jason