planner: handle single partition in IndexJoin correctly #12581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/bugfix
Codecov Report
@@ Coverage Diff @@
## master #12581 +/- ##
================================================
- Coverage 79.9006% 79.8622% -0.0384%
================================================
Files 462 462
Lines 104864 104833 -31
================================================
- Hits 83787 83722 -65
- Misses 14886 14914 +28
- Partials 6191 6197 +6 |
|
/run-all-tests |
alivxxx
reviewed
Oct 10, 2019
|
@eurekaka please resolve the conflicts. |
zz-jason
approved these changes
Oct 15, 2019
zz-jason
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
eurekaka
added a commit
to eurekaka/tidb
that referenced
this pull request
Oct 15, 2019
Conflicts: planner/core/exhaust_physical_plans.go
eurekaka
added a commit
to eurekaka/tidb
that referenced
this pull request
Oct 15, 2019
Conflicts: planner/core/exhaust_physical_plans.go
eurekaka
added a commit
to eurekaka/tidb
that referenced
this pull request
Oct 15, 2019
Conflicts: executor/index_lookup_join_test.go planner/core/exhaust_physical_plans.go
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #12549
What is changed and how it works?
Set
isPartitionandphysicalTableIDforPhysicalIndexScancorrectly when the inner child is a single partition of a partitioned table.Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes
Release note
N/A