-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: make ddl test more stable #12503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #12503 +/- ##
===========================================
Coverage ? 79.9454%
===========================================
Files ? 460
Lines ? 102989
Branches ? 0
===========================================
Hits ? 82335
Misses ? 14687
Partials ? 5967 |
/run-all-tests |
Your auto merge job has been accepted, waiting for 12537 |
/run-all-tests |
@crazycs520 merge failed. |
What problem does this PR solve?
The cause problem is:
As you can see, the schemaVersion is 55, the session doesn't load the latest schema.
The simplest way is set the ddl lease for another test case too, but this method can only reduce the probability of occurrence.
The best method is force make the session to reload schema, we can add
OnChanged
method to do domain.reload forTestDDLCallback
to fix this problem, but this method is a little complicated.Let us just change the lease first.
What is changed and how it works?
Check List
Tests