Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: update kvrpc.Cleanup proto and change its behaviour #12212 #12417

Merged
merged 6 commits into from
Oct 9, 2019
Merged

store: update kvrpc.Cleanup proto and change its behaviour #12212 #12417

merged 6 commits into from
Oct 9, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #12212

@tiancaiamao
Copy link
Contributor Author

PTAL @coocood @youjiali1995 @MyonKeminta

@coocood
Copy link
Member

coocood commented Sep 26, 2019

LGTM

@tiancaiamao tiancaiamao mentioned this pull request Sep 26, 2019
Closed
youjiali1995
youjiali1995 previously approved these changes Oct 8, 2019
View reviewed changes
@tiancaiamao
Copy link
Contributor Author

/run-all-tests

MyonKeminta
MyonKeminta previously approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MyonKeminta
Copy link
Contributor

/run-all-tests tikv=pr/5390

@tiancaiamao
Copy link
Contributor Author

/run-all-tests tikv=pr/5390

MyonKeminta
MyonKeminta approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MyonKeminta MyonKeminta mentioned this pull request Oct 8, 2019
Merged
@MyonKeminta
Copy link
Contributor

Sorry test were run with wrong version of TiKV.
/run-all-tests tikv=pr/5589

@MyonKeminta
Copy link
Contributor

/run-all-tests tikv=pr/5589

@MyonKeminta
Copy link
Contributor

/run-all-tests tikv=release-3.0

@coocood coocood added the status/can-merge Indicates a PR has been approved by a committer. label Oct 8, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 8, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 8, 2019

@tiancaiamao merge failed.

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

Waiting for #12560 to fix CI (go mod tidy)

@tiancaiamao tiancaiamao mentioned this pull request Oct 9, 2019
Merged
@tiancaiamao
Copy link
Contributor Author

/run-integration-common-test tidb-test=pr/908

@tiancaiamao
Copy link
Contributor Author

/run-sqllogic-test-1 tidb-test=pr/908

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao tiancaiamao added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Oct 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 9, 2019

Sorry @tiancaiamao, you don't have permission to trigger auto merge event on this branch.

@coocood coocood merged commit 33f76c9 into pingcap:release-3.0 Oct 9, 2019
@tiancaiamao tiancaiamao deleted the cherry-clean-up branch October 9, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@youjiali1995 youjiali1995 youjiali1995 approved these changes

Assignees
No one assigned
Labels
component/tikv status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiancaiamao @coocood @MyonKeminta @sre-bot @youjiali1995