*: fix panic when check null rejection for from_unixtime
#12413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhang Jian <zjsariel@gmail.com>
Signed-off-by: Zhang Jian <zjsariel@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #12413 +/- ##
===============================================
+ Coverage 79.8085% 80.594% +0.7854%
===============================================
Files 460 460
Lines 102152 106328 +4176
===============================================
+ Hits 81526 85694 +4168
+ Misses 14739 14706 -33
- Partials 5887 5928 +41 |
|
/run-all-tests |
zz-jason
added
needs-cherry-pick-2.1
status/LGT1
qw4990
added
status/can-merge
|
/run-all-tests |
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-3.0 failed |
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Oct 8, 2019
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Oct 8, 2019
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Oct 8, 2019
ngaut
pushed a commit
that referenced
this pull request
Oct 10, 2019
ngaut
pushed a commit
that referenced
this pull request
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhang Jian zjsariel@gmail.com
What problem does this PR solve?
fix #12385
What is changed and how it works?
check whether the argument is NULL before using the value pointer.
Check List
Tests
Code changes
Related changes
Release note