Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: fix ttl manager race #12398

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Conversation

coocood
Copy link
Member

@coocood coocood commented Sep 25, 2019

What problem does this PR solve?

Fix #12396

What is changed and how it works?

run ttlManager after the primary key is successfully set.

Check List

Tests

  • Integration test

@coocood coocood added sig/transaction SIG:Transaction type/bugfix This PR fixes a bug. labels Sep 25, 2019
@tiancaiamao
Copy link
Contributor

/run-all-tests

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2019
@lysu
Copy link
Contributor

lysu commented Sep 25, 2019

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 25, 2019
@lysu
Copy link
Contributor

lysu commented Sep 25, 2019

/rebuild

@zz-jason
Copy link
Member

/run-unit-test

@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Sep 25, 2019
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #12398 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #12398   +/-   ##
=========================================
  Coverage   79.655%   79.655%           
=========================================
  Files          461       461           
  Lines       101401    101401           
=========================================
  Hits         80771     80771           
  Misses       14809     14809           
  Partials      5821      5821

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

@coocood merge failed.

@tiancaiamao
Copy link
Contributor

/run-unit-test

@lysu
Copy link
Contributor

lysu commented Sep 26, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data race in TestSingleStatementRollback
6 participants