-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/tikv: fix ttl manager race #12398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
LGTM |
LGTM |
lysu
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Sep 25, 2019
/rebuild |
/run-unit-test |
ngaut
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Sep 25, 2019
ngaut
approved these changes
Sep 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #12398 +/- ##
=========================================
Coverage 79.655% 79.655%
=========================================
Files 461 461
Lines 101401 101401
=========================================
Hits 80771 80771
Misses 14809 14809
Partials 5821 5821 |
/run-all-tests |
@coocood merge failed. |
/run-unit-test |
/merge |
/run-all-tests |
tiancaiamao
pushed a commit
to tiancaiamao/tidb
that referenced
this pull request
Sep 26, 2019
tiancaiamao
pushed a commit
to tiancaiamao/tidb
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/transaction
SIG:Transaction
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #12396
What is changed and how it works?
run ttlManager after the primary key is successfully set.
Check List
Tests