Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make errcheck works correctly #12381

Merged
merged 5 commits into from
Sep 26, 2019
Merged

build: make errcheck works correctly #12381

merged 5 commits into from
Sep 26, 2019

Conversation

bobotu
Copy link
Contributor

@bobotu bobotu commented Sep 25, 2019

What problem does this PR solve?

Fix the broken errcheck after #11807.

What is changed and how it works?

  • Update the version of golang.org/x/tools used by errcheck
  • Update Makefile to use -ignoretests

Check List

Tests

  • No code

@codecov
Copy link

codecov bot commented Sep 26, 2019 •
edited
Loading

Codecov Report

Merging #12381 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12381   +/-   ##
===========================================
  Coverage   79.8814%   79.8814%           
===========================================
  Files           462        462           
  Lines        102423     102423           
===========================================
  Hits          81817      81817           
  Misses        14738      14738           
  Partials       5868       5868

@bobotu bobotu requested review from Deardrops, SunRunAway and tiancaiamao and removed request for Deardrops and SunRunAway September 26, 2019 06:31
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2019
Deardrops
Deardrops previously approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deardrops Deardrops added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 26, 2019
SunRunAway
SunRunAway approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

Your auto merge job has been accepted, waiting for 11951, 12252

@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit 510a851 into pingcap:master Sep 26, 2019
@bobotu bobotu deleted the fix-errcheck branch September 29, 2019 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway approved these changes

@Deardrops Deardrops Deardrops left review comments

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
component/build status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bobotu @tiancaiamao @sre-bot @SunRunAway @Deardrops @lysu