expression: implement vectorized evaluation for builtinAbsRealSig
#12273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12273 +/- ##
===========================================
Coverage 81.0961% 81.0961%
===========================================
Files 454 454
Lines 98906 98906
===========================================
Hits 80209 80209
Misses 12913 12913
Partials 5784 5784 |
qw4990
reviewed
Sep 22, 2019
remove if condition
zz-jason
reviewed
Sep 23, 2019
| } | ||
| f64s := result.Float64s() | ||
| for i := 0; i < len(f64s); i++ { | ||
| f64s[i] = math.Abs(f64s[i]) |
There was a problem hiding this comment.
would it be faster if we only calculate the non NULL values?
There was a problem hiding this comment.
when only calculate the non NULL values, like that:
if result.IsNull(i) {
continue
}
BenchmarkVectorizedBuiltinMathFunc/builtinAbsRealSig-VecBuiltinFunc-8 500000 3210 ns/op 0 B/op 0 allocs/op
when calculate all values,
BenchmarkVectorizedBuiltinMathFunc/builtinAbsRealSig-VecBuiltinFunc-8 2000000 956 ns/op 0 B/op 0 allocs/op
so, calculate all values is falster.
Reminiscent
added
status/LGT2
|
Your auto merge job has been accepted, waiting for 12298 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
implement vectorized evaluation for
builtinAbsRealSig, for #12105What is changed and how it works?
Check List
Tests