Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Replace Gometalinter to Golangci-lint #12264

Closed
wants to merge 9 commits into from

Conversation

xiekeyi98
Copy link
Contributor

@xiekeyi98 xiekeyi98 commented Sep 18, 2019

What problem does this PR solve?

Because: alecthomas/gometalinter#590
We should replace gometalinter to golangci-lint.

What is changed and how it works?

Change Makefile to use golangci-lint.

Check List

Tests

  • Unit test

This change is Reviewable

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 18, 2019
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #12264 into master will decrease coverage by 0.029%.
The diff coverage is 66.6666%.

@@               Coverage Diff                @@
##             master     #12264        +/-   ##
================================================
- Coverage   81.1041%   81.0751%   -0.0291%     
================================================
  Files           454        454                
  Lines         99186      99076       -110     
================================================
- Hits          80444      80326       -118     
- Misses        12934      12939         +5     
- Partials       5808       5811         +3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants