Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinPowSig #12242

Merged
merged 11 commits into from
Sep 18, 2019
Merged

expression: implement vectorized evaluation for builtinPowSig #12242

merged 11 commits into from
Sep 18, 2019

Conversation

tsthght
Copy link
Contributor

@tsthght tsthght commented Sep 18, 2019 •
edited by qw4990
Loading

What problem does this PR solve?

implement vectorized evaluation for builtinPowSig, for #12105

What is changed and how it works?

BenchmarkVectorizedBuiltinMathFunc/builtinPowSig-VecBuiltinFunc-8               	   50000	     30863 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinPowSig-NonVecBuiltinFunc-8            	   30000	     49697 ns/op	       0 B/op	       0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 18, 2019
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Reminiscent Reminiscent self-requested a review September 18, 2019 02:55
@zz-jason
Copy link
Member

@tsthght Could you update the benchmark result in the PR description?

@codecov
Copy link

codecov bot commented Sep 18, 2019 •
edited
Loading

Codecov Report

Merging #12242 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12242   +/-   ##
===========================================
  Coverage   81.1266%   81.1266%           
===========================================
  Files           454        454           
  Lines         98811      98811           
===========================================
  Hits          80162      80162           
  Misses        12881      12881           
  Partials       5768       5768

qw4990
qw4990 reviewed Sep 18, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990
Copy link
Contributor

qw4990 commented Sep 18, 2019

/run-unit-test

Reminiscent
Reminiscent approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 18, 2019

Your auto merge job has been accepted, waiting for 12253

@Reminiscent Reminiscent removed the request for review from zz-jason September 18, 2019 12:49
@qw4990 qw4990 mentioned this pull request Sep 18, 2019
Closed
48 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Sep 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit a1a308b into pingcap:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@qw4990 qw4990 qw4990 left review comments

@Reminiscent Reminiscent Reminiscent approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tsthght @CLAassistant @zz-jason @qw4990 @sre-bot @Reminiscent @Hokkaitao