Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta/autoid : fix the issue that MaxUint64 and MaxInt64 autoID is incorrectly allocated (#12119) #12210

Merged
merged 1 commit into from
Sep 16, 2019
Merged

meta/autoid : fix the issue that MaxUint64 and MaxInt64 autoID is incorrectly allocated (#12119) #12210

merged 1 commit into from
Sep 16, 2019

Conversation

AilinKid
Copy link
Contributor

cherry-pick to release2.1 #12119

Check List

Tests

  • Unit test
  • Integration test

Release note

  • fix the issue that MaxUint64 and MaxInt64 autoID is incorrectly allocated.

@AilinKid
Copy link
Contributor Author

/run-all-tests

bb7133
bb7133 reviewed Sep 16, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2019
Deardrops
Deardrops approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@Deardrops Deardrops added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 16, 2019
@winkyao winkyao merged commit 896e13d into pingcap:release-2.1 Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@Deardrops Deardrops Deardrops approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AilinKid @bb7133 @Deardrops @winkyao