Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: go generate builtin_control_vec.go #12140

Merged
merged 9 commits into from
Sep 12, 2019
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ errcheck:tools/bin/errcheck
@echo "errcheck"
@GO111MODULE=on tools/bin/errcheck -exclude ./tools/check/errcheck_excludes.txt -blank $(PACKAGES) | grep -v "_test\.go" | awk '{print} END{if(NR>0) {exit 1}}'

gogenerate:
@echo "go generate ./..."
./tools/check/check-gogenerate.sh

lint:tools/bin/revive
@echo "linting"
@tools/bin/revive -formatter friendly -config tools/check/revive.toml $(FILES)
Expand All @@ -117,7 +121,7 @@ clean:
rm -rf *.out
rm -rf parser

test: checklist checkdep gotest explaintest
test: checklist checkdep gotest explaintest gogenerate

explaintest: server
@cd cmd/explaintest && ./run-tests.sh -s ../../bin/tidb-server
Expand Down
2 changes: 1 addition & 1 deletion expression/bench_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ func testVectorizedBuiltinFunc(c *C, vecExprCases vecExprBenchCases) {
c.Assert(err, IsNil)
c.Assert(isNull, Equals, output.IsNull(i))
if !isNull {
c.Assert(val, Equals, d64s[i])
c.Assert(val.Duration, Equals, d64s[i])
}
i++
}
Expand Down
2 changes: 2 additions & 0 deletions expression/builtin.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//go:generate go run generator/control_vec.go

package expression

import (
Expand Down
75 changes: 0 additions & 75 deletions expression/builtin_control_vec.go

This file was deleted.

Loading