*: replace pessimistic default config option with global variable #12041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12041 +/- ##
================================================
- Coverage 81.4711% 81.3505% -0.1207%
================================================
Files 447 447
Lines 95759 95649 -110
================================================
- Hits 78016 77811 -205
- Misses 12181 12303 +122
+ Partials 5562 5535 -27 |
|
LGTM |
AndreMouche
approved these changes
Sep 5, 2019
AndreMouche
added
the
status/can-merge
|
/run-all-tests |
|
@coocood merge failed. |
|
/run-unit-test |
|
cherry pick to release-3.0 failed |
This was referenced Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The 'PessimisticTxn.Default' option in the
Configrequires a server restart to change.It can be inconsistent for multiple servers.
What is changed and how it works?
tidb_txn_modesystem variable.PessimisticTxn.Defaultoption in the config.PessimisticTxn.Enableto true.Check List
Tests
Code changes
Related changes
tidb-ansiblerepositoryRelease note
tidb_txn_modesystem variable, setenableoption to 'true' and removedefaultoption in the[pessimistic-txn]section of the config file.