*: implement the TxnHeartBeat API for the large transaction #11979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
added
sig/transaction
Codecov Report
@@ Coverage Diff @@
## master #11979 +/- ##
===========================================
Coverage 81.9618% 81.9618%
===========================================
Files 447 447
Lines 97848 97848
===========================================
Hits 80198 80198
Misses 12111 12111
Partials 5539 5539 |
youjiali1995
reviewed
Sep 2, 2019
coocood
reviewed
Sep 3, 2019
coocood
reviewed
Sep 3, 2019
coocood
reviewed
Sep 3, 2019
|
LGTM |
tiancaiamao
added
needs-cherry-pick-3.0
and removed
sig/transaction
|
/run-all-tests |
|
/rebuild |
|
/rebuild |
|
Is it expected that go.mod and go.sum has so many changes? I think only updating kvproto shouldn't cause so many changes. |
It's expected. @MyonKeminta |
|
/run-all-tests tidb-test=pr/881 |
|
/run-all-tests |
coocood
reviewed
Sep 5, 2019
|
/run-all-tests |
|
/run-integration-common-test tikv=pr/5407 |
1 similar comment
|
/run-integration-common-test tikv=pr/5407 |
|
/run-all-tests tikv=pr/5407 |
tiancaiamao
added
status/all tests passed
status/LGT2
|
/run-all-tests tikv=pr/5407 |
|
/run-unit-test tikv=pr/5407 |
|
/run-all-tests |
coocood
approved these changes
Sep 9, 2019
|
cherry pick to release-3.0 failed |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Sep 25, 2019
sre-bot
pushed a commit
that referenced
this pull request
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In the implementation of the large transaction, a large transaction may last for a long time, during which we must ensure that the lock of the transaction will not been cleaned up.
So we need a new API in the kvproto to update the TTL of a transaction, namely
TxnHeartBeat.What is changed and how it works?
Implement the TxnHeartBeat API in the mocktikv, add the unit test.
Check List
Tests
Code changes