-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: support query block hint #11861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11861 +/- ##
===========================================
Coverage 81.5803% 81.5803%
===========================================
Files 443 443
Lines 96066 96066
===========================================
Hits 78371 78371
Misses 12218 12218
Partials 5477 5477 |
eurekaka
reviewed
Aug 26, 2019
eurekaka
reviewed
Aug 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
winoros
reviewed
Aug 28, 2019
winoros
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
alivxxx
added
status/LGT2
Indicates that a PR has LGTM 2.
status/can-merge
Indicates a PR has been approved by a committer.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Aug 29, 2019
/run-all-tests |
@lamxTyler merge failed. |
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/new-feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support using query block in optimizer hint.
What is changed and how it works?
This PR will first tranverse the ast and assign the offset of stmt within the sql from left to right, then group hints in a top down style and let them take effects at specific query block.
Check List
Tests
Code changes
Side effects
Related changes