expression: fix constItem() and column-pruning in order by clause
#11839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11839 +/- ##
===========================================
Coverage 81.2937% 81.2937%
===========================================
Files 438 438
Lines 94578 94578
===========================================
Hits 76886 76886
Misses 12217 12217
Partials 5475 5475 |
|
/run-common-test |
qw4990
reviewed
Aug 27, 2019
qw4990
reviewed
Aug 27, 2019
wjhuang2016
force-pushed
the
fix_constitem
branch
from
83ef6c6 to
3d09508
Compare
eurekaka
reviewed
Aug 27, 2019
Done |
|
/run-all-tests |
zz-jason
reviewed
Aug 28, 2019
wjhuang2016
force-pushed
the
fix_constitem
branch
from
ceb7e05 to
6ef37fb
Compare
eurekaka
reviewed
Aug 28, 2019
eurekaka
added
contribution
eurekaka
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @wjhuang2016 PTAL. |
This was referenced Apr 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#10064 Change the semantics of constItem().
A const item can be eval() when build a plan, and it shouldn't contain
correlated column.Column-pruning in
order byclause, however, need to identify a "const item" in execute stage. AndIsMutableEffectsExprshould be enough.What is changed and how it works?
Change back constItem() and use
IsMutableEffectsExpr. And exportisMutableEffectsExprasIsMutableEffectsExprCheck List
Tests
Pass the test add by planner: keep unfoldable exprs when pruning columns for ORDER BY items #10064.
Code changes
Side effects
Related changes