Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix uncorrect behavior of index join (#11724) #11759

Merged
merged 1 commit into from
Aug 16, 2019
Merged

planner: fix uncorrect behavior of index join (#11724) #11759

merged 1 commit into from
Aug 16, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Aug 16, 2019

What problem does this PR solve?

pick #11724

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release note

@winoros winoros added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Aug 16, 2019
@winoros
Copy link
Member Author

winoros commented Aug 16, 2019

/run-all-tests

eurekaka
eurekaka reviewed Aug 16, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2019
lzmhhh123
lzmhhh123 approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 16, 2019

Sorry @lzmhhh123, you don't have permission to trigger auto merge event on this branch.

@eurekaka eurekaka merged commit 43aaf9a into pingcap:release-3.0 Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@alivxxx alivxxx Awaiting requested review from alivxxx

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@winoros @sre-bot @eurekaka @lzmhhh123