Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove the NotNullFlag for aggregation func MAX/MIN when inferring type (#11343) #11641

Merged
merged 4 commits into from
Aug 8, 2019

Conversation

SunRunAway
Copy link
Contributor

cherry-pick #11343 to release-3.0


What problem does this PR solve?

Fix issue #11332

What is changed and how it works?

IF scalefunc is MAX or MIN, remove not null flag.

Check List

Tests

  • Unit test

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2019
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. status/PTAL labels Aug 6, 2019
@zz-jason zz-jason removed their request for review August 6, 2019 10:40
@sre-bot
Copy link
Contributor

sre-bot commented Aug 6, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 6, 2019

@SunRunAway merge failed.

@zz-jason
Copy link
Member

zz-jason commented Aug 7, 2019

/run-auto-merge

@sre-bot
Copy link
Contributor

sre-bot commented Aug 7, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 7, 2019

@SunRunAway merge failed.

@SunRunAway
Copy link
Contributor Author

/run-unit-test

@SunRunAway
Copy link
Contributor Author

/run-auto-merge

@sre-bot
Copy link
Contributor

sre-bot commented Aug 8, 2019

/run-all-tests

@sre-bot sre-bot merged commit 00801a7 into pingcap:release-3.0 Aug 8, 2019
@SunRunAway SunRunAway deleted the cp branch August 8, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants