Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranger: BuildColumnRange should merge ranges when column has prefix len #11563

Merged
merged 4 commits into from
Aug 1, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Aug 1, 2019

What problem does this PR solve?

Fix the second case of #11544

What is changed and how it works?

BuildColumnRange should union the ranges if it has been cut.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #11563 into master will increase coverage by 0.1091%.
The diff coverage is 33.3333%.

@@               Coverage Diff                @@
##             master     #11563        +/-   ##
================================================
+ Coverage   81.2152%   81.3243%   +0.1091%     
================================================
  Files           426        425         -1     
  Lines         91835      91424       -411     
================================================
- Hits          74584      74350       -234     
+ Misses        11894      11731       -163     
+ Partials       5357       5343        -14

@winoros winoros requested a review from alivxxx August 1, 2019 07:09
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 1, 2019
@winoros winoros requested a review from lzmhhh123 August 1, 2019 08:17
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 1, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2019

cherry pick to release-3.0 in PR #11565

@winoros winoros deleted the fix-build-column-range branch August 1, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants