fix error in ConvertJSONToInt error msg #11493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
H-ZeX
added
component/expression
needs-cherry-pick-2.1
type/bugfix
Codecov Report
@@ Coverage Diff @@
## master #11493 +/- ##
================================================
- Coverage 81.3808% 81.3612% -0.0196%
================================================
Files 424 424
Lines 90917 90902 -15
================================================
- Hits 73989 73959 -30
- Misses 11609 11626 +17
+ Partials 5319 5317 -2 |
Codecov Report
@@ Coverage Diff @@
## master #11493 +/- ##
===========================================
Coverage 81.3489% 81.3489%
===========================================
Files 425 425
Lines 91389 91389
===========================================
Hits 74344 74344
Misses 11713 11713
Partials 5332 5332 |
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
lzmhhh123
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #11534 |
|
cherry pick to release-2.1 failed |
zz-jason
pushed a commit
that referenced
this pull request
Aug 1, 2019
sre-bot
pushed a commit
that referenced
this pull request
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: H-ZeX hzx20112012@gmail.com
What problem does this PR solve?
The origin version will call overflow with
mysql.TypeDoublewhen json of type float convert to int overflow i64::MAX, however, it is overflow i64::MAX but not f64::MAX.What is changed and how it works?
replace
mysql.TypeDoublewithmysql.TypeLonglong.Check List
Code changes
No.
Side effects
No.
Related changes
No.