Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add aggregation hints
TIDB_HASHAGG
andTIDB_STREAMAGG
#11364planner: add aggregation hints
TIDB_HASHAGG
andTIDB_STREAMAGG
#11364Changes from 28 commits
e87fad5
0184392
1f0e8c4
9a1a791
61bf4f9
614c48a
6f76567
439cfdb
6ed0a73
02e66a2
0030309
8781ad9
9d7b535
f31b208
d885b69
e68192c
71e19c7
7213db8
e52d87c
c90dc26
24f8229
62b041b
3226dc9
a7829f6
885ca2d
0b1acff
7dd61f9
d2246e5
0a122d6
8c49116
9d4c316
2609f8b
081b602
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If !preferStream && len(la.possibleProperties) == 0 || !all ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not resolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about extract a common error message pattern for conflicted optimizer hints. For example:
The above error can be used this way:
Example usage for Join:
You can improve the above error message by replacing
TIDB_HASHAGG()
with the string extracted from the AST node, which is written by the user.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do this later, in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you file an issue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test case which contains subquery?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the first one, because
possibleChildProperties
are only possible... We'd better not rely too much on it, I handle this in line 1272 - 1275, you can take a look.For the test case, I will add them soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When adding test case, find another bug. Fix it soon...