Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: support more analyze options #11278

Merged
merged 7 commits into from
Jul 25, 2019
Merged

stats: support more analyze options #11278

merged 7 commits into from
Jul 25, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jul 16, 2019

What problem does this PR solve?

Support more analyze options.

What is changed and how it works?

Support syntax like analyze table t with 4 buckets, 1 topn, 4 cmsketch width, 4 cmsketch depth to control the number of topn and the depth and width of cm sketch.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to update the documentation

@alivxxx alivxxx added type/enhancement The issue or PR belongs to an enhancement. component/statistics labels Jul 16, 2019
@alivxxx alivxxx mentioned this pull request Jul 16, 2019
Merged
@codecov
Copy link

codecov bot commented Jul 23, 2019 •
edited
Loading

Codecov Report

Merging #11278 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11278   +/-   ##
===========================================
  Coverage   81.5371%   81.5371%           
===========================================
  Files           424        424           
  Lines         91432      91432           
===========================================
  Hits          74551      74551           
  Misses        11571      11571           
  Partials       5310       5310

lzmhhh123
lzmhhh123 reviewed Jul 23, 2019
View reviewed changes
planner/core/planbuilder.go Outdated Show resolved Hide resolved
executor/analyze_test.go Outdated Show resolved Hide resolved
planner/core/planbuilder.go Outdated Show resolved Hide resolved
@alivxxx alivxxx requested a review from lzmhhh123 July 24, 2019 02:41
lzmhhh123
lzmhhh123 reviewed Jul 24, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2019
@alivxxx
Copy link
Contributor Author

alivxxx commented Jul 24, 2019

/run-all-tests

@alivxxx
Copy link
Contributor Author

alivxxx commented Jul 24, 2019

/run-unit-test

winoros
winoros approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 25, 2019
@alivxxx alivxxx merged commit 268cbf1 into pingcap:master Jul 25, 2019
@alivxxx alivxxx deleted the analyze-options branch July 25, 2019 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@winoros winoros winoros approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
component/statistics status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alivxxx @winoros @lzmhhh123 @crazycs520