Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix privilege check for 'show create user current_user()' (#11142) #11229

Merged
merged 4 commits into from
Jul 15, 2019
Merged

executor: fix privilege check for 'show create user current_user()' (#11142) #11229

merged 4 commits into from
Jul 15, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #11142

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #11229 into master will decrease coverage by 2.8756%.
The diff coverage is 69.3229%.

@@               Coverage Diff                @@
##             master     #11229        +/-   ##
================================================
- Coverage   81.2235%   78.3479%   -2.8757%     
================================================
  Files           423        417         -6     
  Lines         90230      89354       -876     
================================================
- Hits          73288      70007      -3281     
- Misses        11634      14024      +2390     
- Partials       5308       5323        +15

@codecov
Copy link

codecov bot commented Jul 12, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-3.0@ea59413). Click here to learn what that means.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             release-3.0     #11229   +/-   ##
================================================
  Coverage               ?   78.3479%           
================================================
  Files                  ?        417           
  Lines                  ?      89354           
  Branches               ?          0           
================================================
  Hits                   ?      70007           
  Misses                 ?      14024           
  Partials               ?       5323

@tiancaiamao tiancaiamao changed the base branch from master to release-3.0 July 12, 2019 06:40
@tiancaiamao
Copy link
Contributor Author

PTAL @imtbkcat @jackysp

@imtbkcat
Copy link

/run-all-tests

imtbkcat
imtbkcat reviewed Jul 12, 2019
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao tiancaiamao added status/all tests passed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 12, 2019
jackysp
jackysp approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2019
@zz-jason zz-jason merged commit 36f9978 into pingcap:release-3.0 Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imtbkcat imtbkcat imtbkcat left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
component/privilege priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @imtbkcat @jackysp @zz-jason