-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add trace support for the AllocAutoIncrementValue
function
#11158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllocAutoIncrementValue may need to visit the network and be slow, add trace for it
Great! |
jackysp
reviewed
Jul 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-unit-test |
PTAL @lysu |
lysu
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #11158 +/- ##
===========================================
Coverage 81.0651% 81.0651%
===========================================
Files 423 423
Lines 90051 90051
===========================================
Hits 73000 73000
Misses 11773 11773
Partials 5278 5278 |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Jul 12, 2019
jackysp
pushed a commit
that referenced
this pull request
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/LGT2
Indicates that a PR has LGTM 2.
type/enhancement
The issue or PR belongs to an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
AllocAutoIncrementValue
may need to visit the network and be slow, add trace support for it.For example, from the following image, we can see that dominant cost in
InsertExec.Next
isAllocAutoIncrementValue
.And
AllocAutoIncrementValue
is much faster after the first time it's been executed, because alloc would cache a batch of ids:What is changed and how it works?
Add those lines to
AllocAutoIncrementValue
:Tiny refactor for the
ctx
parameter inAllocAutoIncrementValue
.Check List
Tests
Code changes