-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: fix overflow check of types/convert.go::floatStrToIntStr #11114
Merged
Merged
Changes from 20 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
f472fab
types: fix overflow check of floatStrToIntStr
H-ZeX a26272d
fix overflow check
H-ZeX 81d6cf9
improve test converage
H-ZeX 26f52f3
Merge branch 'master' into fix_overflow_check
H-ZeX ab82a67
improve test converage
H-ZeX 9c27a8d
Merge branch 'fix_overflow_check' of github.com:pingcap/tidb into fix…
H-ZeX 1d2ba4b
fix unit test
H-ZeX 15ca9d6
Merge branch 'master' into fix_overflow_check
H-ZeX 4b8109e
Merge branch 'master' into fix_overflow_check
lonng 66e19e3
remove isOverflowInt64 check
H-ZeX 4edb2ee
Merge branch 'fix_overflow_check' of github.com:pingcap/tidb into fix…
H-ZeX 9062ef4
Merge branch 'master' into fix_overflow_check
lonng 06c0fb7
Merge branch 'master' into fix_overflow_check
lonng 627a573
fix a bug
H-ZeX 14467f1
Merge branch 'fix_overflow_check' of github.com:pingcap/tidb into fix…
H-ZeX b2e81af
Merge branch 'master' into fix_overflow_check
lonng 7bffb9c
fix a bug
H-ZeX f6a30d4
Merge branch 'fix_overflow_check' of github.com:pingcap/tidb into fix…
H-ZeX 4d65064
Merge branch 'master' into fix_overflow_check
lonng 5cd0090
Merge branch 'master' into fix_overflow_check
lonng d611ddf
Merge branch 'master' into fix_overflow_check
lonng 8aa2827
Merge branch 'master' into fix_overflow_check
lonng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
intCnt
will never be negative according to the L448.Prefer to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intCnt>=0, exp>=0, however, if exp=I64::MAX, intCnt>0, then their sum will overflow and get negative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
intCnt < 0
will early return in L451.